Rename module_utils/elb_utils.py to module_utils/elbv2_utils.py#2285
Rename module_utils/elb_utils.py to module_utils/elbv2_utils.py#2285alinabuzachis wants to merge 3 commits intoansible-collections:mainfrom
Conversation
alinabuzachis
force-pushed
the
remane_elb_utils
branch
from
30484df to
1423c6d
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 41s |
|
Not completely against the idea of moving this code about, but will ask the question if I'd either go for |
To answer my own question here. We can't use
Personally I think this policy is being a little overly restrictive, but it is what it is. |
… it include util esed by the elbv2 client Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
remane_elb_utils
branch
from
1423c6d to
ea10aae
Compare
Signed-off-by: Alina Buzachis <[email protected]>
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 8m 12s |
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
There was a problem hiding this comment.
| minor_changes: | |
| breaking_changes: |
Technically this is a breaking change, but I think it's the right change to make in this case.
Further thought:
It's a breaking change because someone can in theory import from module_utils/elb_utils/...
Do we want people directly importing things from module_utils/elbv2_utils ? The bulk of this code is just calls wrapped with helpers.
Do we in fact move this to module_utils/_elbv2 (marking the module private), and only directly import AnsibleELBv2Error which we want to publicly expose (for the other calls we import ._elbv2 _elbv2_utils and then do things like _elbv2_utils.describe_load_balancer_attributes(self.connection, self.elb["LoadBalancerArn"])
) SUMMARY The data tagging feature has been merged into the main branch; we need to fix the integration tests to be compatible with the new changes. Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4579add
) SUMMARY The data tagging feature has been merged into the main branch; we need to fix the integration tests to be compatible with the new changes. Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4579add
) SUMMARY The data tagging feature has been merged into the main branch; we need to fix the integration tests to be compatible with the new changes. Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4579add
2 participants
SUMMARY
Rename module_utils/elb_utils.py to module_utils/elbv2_utils.py, since it includes utilities for the elbv2 client and we may also have utilities just for elb.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION